Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve holiday definitions for The Netherlands #435

Merged

Conversation

ehoogeveen-medweb
Copy link
Contributor

@ehoogeveen-medweb ehoogeveen-medweb commented Oct 27, 2023

  • Changed type of Goede Vrijdag (Good Friday) from public to school
  • Changed type of Bevrijdingsdag (Liberation Day) from observance to school
  • Set name of Ascension Day to Hemelvaartsdag as an override
  • Add historical definitions for Koninginnedag (Queen's Day) and Princessedag (Princess Day)
    • Queen's Day was celebrated prior to 2014 so it might have real world relevance. I added the older variants for completeness.
  • Add English translations for Bevrijdingsdag (Liberation Day) and Prinsjesdag (Prince's Day)

Technically several of these holidays can be seen as "optional" as there's no legal requirement, but most people are free and they're school holidays as well, so I left them as public. Let me know if it would be better to change them.

Fixes #434.

* Change type of Goede Vrijdag (Good Friday) from public to school
* Change type of Bevrijdingsdag (Liberation Day) from observance to school
* Set name of Ascension Day to Hemelvaartsdag as an override
* Add historical definitions for Koninginnedag (Queen's Day) and Princessedag (Princess Day)
* Add English translations for Bevrijdingsdag (Liberation Day) and Prinsjesdag (Prince's Day)
@commenthol commenthol merged commit cd47dc7 into commenthol:master Nov 4, 2023
3 checks passed
@commenthol
Copy link
Owner

@ehoogeveen-medweb, Great, many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistencies in classification of Dutch public holidays
2 participants