Inconsistencies in classification of Dutch public holidays

[ehoogeveen-medweb]

I noticed that Goede vrijdag (Good Friday) is marked as a public holiday, but Bevrijdingsdag (Liberation Day) is not.

Both are official public holidays:

• Dutch
• English

However, not everyone is entitled to a free day on the following public holidays (unfortunately I think these pages are only available in Dutch):

• Goede vrijdag (Good Friday): A regular work day for most people
• Koningsdag (King’s Day): Most people have the day off
• Bevrijdingsdag (Liberation Day): It just says to check with your employer
• Hemelvaartsdag (Ascension Day): Most people have the day off
• Tweede pinksterdag (Whit Monday): Most people have the day off (but it says to check with your employer)

So I'm not entirely sure how they should be classified within date-holidays, but if Liberation Day is optional then Good Friday should probably be optional as well.

[commenthol]

Hi @ehoogeveen-medweb ,

The definitions of holidays can be found in https://github.com/commenthol/date-holidays/blob/master/docs/specification.md#types-of-holidays

For optional holidays where only "special" groups are entitled to enjoy them, I'd recommend to add a note stating that "constraint".
I'd appreciate if you could file a Pull-Request on the findings you have made.