Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload only on autoload path file changes #930

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reload only on autoload path file changes #930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Reload only on autoload path file changes
  • Loading branch information
@stuwil
stuwil committed Apr 10, 2017
commit ab3e23fa9ef76a3fbb56493d101debf55403e2af
2 changes: 1 addition & 1 deletion lib/delayed/worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def self.setup_lifecycle
end

def self.reload_app?
defined?(ActionDispatch::Reloader) && Rails.application.config.cache_classes == false
Rails.application.reloaders.any?(&:updated?) && Rails.application.config.cache_classes == false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the Rails.application.config.cache_classes == false check is constant (performance-wise) and Rails.application.reloaders.any?(&:updated?) is not, you should swap the order of these checks.

end

def self.delay_job?(job)
Expand Down