Reload only on autoload path file changes #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixed the issues I was having with DJ on Rails 5 👍 |
stuwil
force-pushed
the
reload-on-change
branch
from
d7fb073
to
ab3e23f
Compare
|
This PR also fixes issues I've been having with Delayed Jobs on Rails 5.1 too. Thanks @stuwil. |
stwr667
reviewed
Jul 17, 2018
| @@ -116,7 +116,7 @@ def self.setup_lifecycle | |||
| end | |||
|
|
|||
| def self.reload_app? | |||
| defined?(ActionDispatch::Reloader) && Rails.application.config.cache_classes == false | |||
| Rails.application.reloaders.any?(&:updated?) && Rails.application.config.cache_classes == false | |||
There was a problem hiding this comment.
Given that the Rails.application.config.cache_classes == false check is constant (performance-wise) and Rails.application.reloaders.any?(&:updated?) is not, you should swap the order of these checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting this from #929. This should close #776.
Currently, the app reloader is invoked constantly when Rails.application.config.cache_classes is false. Rails 3.2+ only reloads when files in the autoload path are changed, this implements the same behaviour.