allow —-kill-waittime parameter to specify the kill timeout #925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As already described in #459 , the default kill timeout of 20 seconds of the daemons gem might be not appropriate for every project, especially when having long running jobs. Currently, it is not possible to pass a different timeout, even #916 doesn't help here because the
force_kill_waittime
is a Ruby option.Based on the work of @pacoguzman in #459 , I added an additional command parameter
--kill-waittime=n
.