Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-wait and force-kill-waittime options to Delayed::Comand #459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add no-wait and force-kill-waittime options to Delayed::Comand #459

wants to merge 1 commit into from

Conversation

pacoguzman
Copy link

I've added support to these options that are used for Daemons gems.

In our case we have some long running jobs that we don't want to be locked when the process is killed on a new deployment, with these we avoid that problem and the process is going to still running after the current job is completed. Later our monitor system will start a new process.

What do you think? is this too specific to the daemons gem? I don't find another way to pass options to the daemons gem

@pacoguzman
Copy link
Author

Some news with this

@asamix
Copy link

asamix commented Dec 26, 2012

I want to use this. Because, delayed_job's process was frequently force-killed on restart them.

@asamix
Copy link

asamix commented Dec 26, 2012

asamix@f762cf7

@sferik sferik force-pushed the master branch 2 times, most recently from 00c7e65 to 27ce6b0 Compare October 8, 2014 16:38
@adamniedzielski
Copy link

Will you accept this pull request if I rewrite it to work with current master? I think that it's really useful especially when you suffer from "process with pid X won't stop, we forcefully kill it" as described in #593 /cc @albus522

@tiredenzo
Copy link

Is it possible to resolve conflicts in this
I think that this feature should be integrated please.

@albus522
Copy link
Member

Does this require a specific min version of the daemons gem?

@apurvis
Copy link

apurvis commented May 16, 2016

👍

@rfroetscher
Copy link

have a more flexible solution that works with any version of the daemons gem here #916

@mike-stewart
Copy link

Any plans to update this PR now that #916 was merged? It looks like we would still need the force_kill_waittime option in Delayed::Comand, since it is not an accepted command line option in the daemons gem, so couldn't be passed through daemon-options.

@lacco
Copy link

lacco commented Jun 22, 2016

After some research in one of my projects, I agree with @mike-stewart : #916 doesn't solve the problem of passing the force_kill_waittime option, we need another change to support this.

@c960657
Copy link

c960657 commented Apr 26, 2018

A new switch, --force_kill_waittime, has been added to Daemons in thuehlinger/daemons#65 (not yet released).

@c960657
Copy link

c960657 commented Dec 13, 2018

The new --force_kill_waittime switch for Daemons is included in the recent 1.3 release.

@joshuapinter
Copy link

Can this Issue be closed since --force_kill_waittime switch has been added to the Daemons gem and no longer needs to be explicitly supported internally in delayed_job?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet