Skip to content

Commit

Permalink
Remove tsconfig files - they are not part of build process (denoland#…
Browse files Browse the repository at this point in the history
  • Loading branch information
ry committed Nov 4, 2019
1 parent 0644f9c commit c04ff22
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 62 deletions.
1 change: 0 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"root": true,
"parser": "@typescript-eslint/parser",
"parserOptions": {
"project": "./tsconfig.json",
"createDefaultProgram": true
},
"plugins": ["@typescript-eslint"],
Expand Down
6 changes: 1 addition & 5 deletions cli/flags.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,7 @@ pub struct DenoFlags {
pub log_level: Option<Level>,
pub version: bool,
pub reload: bool,
/// When the `--config`/`-c` flag is used to pass the name, this will be set
/// the path passed on the command line, otherwise `None`.
pub config_path: Option<String>,
/// When the `--importmap` flag is used to pass the name, this will be set
/// the path passed on the command line, otherwise `None`.
pub import_map_path: Option<String>,
pub allow_read: bool,
pub read_whitelist: Vec<String>,
Expand Down Expand Up @@ -192,7 +188,7 @@ To get help on the another subcommands (run in this case):
.short("c")
.long("config")
.value_name("FILE")
.help("Load compiler configuration file")
.help("Load tsconfig.json configuration file")
.takes_value(true)
.global(true),
)
Expand Down
12 changes: 5 additions & 7 deletions std/http/file_server_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,16 @@ function killFileServer(): void {
test(async function serveFile(): Promise<void> {
await startFileServer();
try {
const res = await fetch("http:https://localhost:4500/tsconfig.json");
const res = await fetch("http:https://localhost:4500/README.md");
assert(res.headers.has("access-control-allow-origin"));
assert(res.headers.has("access-control-allow-headers"));
assertEquals(
res.headers.get("content-type"),
"application/json; charset=utf-8"
"text/markdown; charset=utf-8"
);
const downloadedFile = await res.text();
const localFile = new TextDecoder().decode(
await Deno.readFile("./tsconfig.json")
await Deno.readFile("README.md")
);
assertEquals(downloadedFile, localFile);
} finally {
Expand All @@ -57,7 +57,7 @@ test(async function serveDirectory(): Promise<void> {
assert(res.headers.has("access-control-allow-origin"));
assert(res.headers.has("access-control-allow-headers"));
const page = await res.text();
assert(page.includes("tsconfig.json"));
assert(page.includes("README.md"));

// `Deno.FileInfo` is not completely compatible with Windows yet
// TODO: `mode` should work correctly in the future.
Expand All @@ -66,9 +66,7 @@ test(async function serveDirectory(): Promise<void> {
assert(/<td class="mode">\([a-zA-Z-]{10}\)<\/td>/.test(page));
Deno.build.os === "win" &&
assert(/<td class="mode">\(unknown mode\)<\/td>/.test(page));
assert(
page.includes(`<td><a href="/tsconfig.json">tsconfig.json</a></td>`)
);
assert(page.includes(`<td><a href="/README.md">README.md</a></td>`));
} finally {
killFileServer();
}
Expand Down
15 changes: 0 additions & 15 deletions std/tsconfig.json

This file was deleted.

5 changes: 0 additions & 5 deletions std/tsconfig.test.json

This file was deleted.

29 changes: 0 additions & 29 deletions tsconfig.json

This file was deleted.

0 comments on commit c04ff22

Please sign in to comment.