Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tsconfig files - they are not part of build process #3262

Merged
merged 5 commits into from
Nov 4, 2019

Conversation

ry
Copy link
Member

@ry ry commented Nov 4, 2019

No description provided.

@bartlomieju
Copy link
Member

I strongly opt to keep std/tsconfig.test.json - it ensures standard library code is written in such a way it passes strict type checks.

@ry
Copy link
Member Author

ry commented Nov 4, 2019

@bartlomieju where is that specified?

~/src/deno> grep -R tsconfig.test.json .
./third_party/v8/tools/turbolizer/package.json
9:    "test": "ts-mocha -p tsconfig.test.json test/**/*-test.ts",
~/src/deno>

@bartlomieju
Copy link
Member

@ry looks like it got removed during merging of deno_std.
It was used before in CI:
https://github.com/denoland/deno_std/blob/master/.ci/template.common.yml

@ry ry requested a review from piscisaureus November 4, 2019 16:43
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative LGTM.
I think ensuring that std is compatible with strict mode is pretty important, so please fix that with some priority.

@ry
Copy link
Member Author

ry commented Nov 4, 2019

Added #3266 to resolve the strict type checking.

@ry ry merged commit c04ff22 into denoland:master Nov 4, 2019
@ry ry deleted the rm_tsconfig branch November 4, 2019 23:13
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants