Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reboot map with support for House and Senate #36

Merged
merged 3 commits into from
Feb 1, 2021

Conversation

bhrutledge
Copy link
Collaborator

Closes #21, supersedes #25

Changes:

Kapture.2021-01-31.at.18.12.46.mp4


/* Templates for map elements */

const districtLegend = () => /* html */`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted to keep all of the template functions within this scope because I think it's easier to follow.

@bhrutledge bhrutledge changed the title Reboot map Reboot map with support for House and Senate Jan 31, 2021
@bhrutledge
Copy link
Collaborator Author

@d-ondrich Since you did the original work, can you take a look at this? Also FYI @bhinebaugh.

@d-ondrich
Copy link
Collaborator

LGTM

@d-ondrich d-ondrich merged commit 3c84b39 into codeforboston:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a Senate/House toggle on the Map component
2 participants