Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made URL in map component passed in as prop #30

Closed
wants to merge 1 commit into from

Conversation

NONstiky
Copy link
Collaborator

Looks like I my IDE also make a bunch of style changes. Could get rid of those if people prefer.

@bhrutledge
Copy link
Collaborator

@NONstiky Apologies for being a wet blanket, but in light of #20 (comment), are you game to close this?

Looks like I my IDE also make a bunch of style changes. Could get rid of those if people prefer.

I think it's best practice to avoid unrelated formatting changes in PR's. It makes them easier to review and less likely to cause conflicts. Also, I would only use a code formatter on a project that has explicitly adopted a style (ideally with a linter and CI to enforce it).

@NONstiky NONstiky closed this Jan 28, 2021
@NONstiky
Copy link
Collaborator Author

@bhrutledge Please don't apologize. I totally agree with you which is why I mentioned the style changes, I was just rushed to opening this PR while we were in the meeting.

We should probably unify around an explicitly adopted a style as you mention to prevent collisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants