Mail to legislators and show stored testimony into EditTestimony modal #281
Conversation
…eeding mailing tool
…howAddComment becomes showTestimony
|
Visit the preview URL for this PR (updated for commit jkoren/advocacy-maps@c21ad30): https://digital-testimony-dev--pr281-mail-to-legislators-qoxqzt34.web.app (expires Wed, 16 Mar 2022 16:49:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bc0858669d4997df2a9165c2144bd1e2dbba0242 |
…displayName in BillTestimonies.js
…ny and BillTestimonies
| const senatorEmail = senatorId ? GetMemberEmail(senatorId) : "" | ||
| const representativeEmail = representativeId ? GetMemberEmail(representativeId) : "" |
There was a problem hiding this comment.
If I have legislators selected, these lines cause an error. One of the rules of hooks is not to call hooks conditionally. Since GetMemberEmail calls useMembers, we're violating that rule. things seem to work with these lines:
const senator = useMember(profile?.senator?.id)
const senatorEmail = senator.member?.EmailAddress ?? ""
const representative = useMember(profile?.representative?.id)
const representativeEmail = representative.member?.EmailAddress ?? ""
There was a problem hiding this comment.
nice! I updated the code.
| const edit = useEditTestimony(user.uid, bill.BillNumber) | ||
| const positionMessage = "Select my support..(required)" | ||
|
|
||
| const url = `mailto:${senatorEmail},${representativeEmail}?subject=My testimony on Bill ${bill ? bill.BillNumber : ""}&body=${testimony ? testimony.content : ""}` |
There was a problem hiding this comment.
We should wrap this url in encodeURI. Some characters like newlines and spaces aren't allowed in URL's. This converts them to escape strings like %20 so they show up correctly in the email draft
const url = encodeURI(`mailto:${senatorEmail},${representativeEmail}?subject=My testimony on Bill ${bill ? bill.BillNumber : ""}&body=${testimony ? testimony.content : ""}`)
|
|
||
| const publishTestimony = async () => { | ||
| if (testimony.position == undefined || testimony.position == positionMessage) { return } | ||
| handleCloseTestimony() |
There was a problem hiding this comment.
let's move this down two lines, so the modal closes after the testimony is published.
Also, what do you think about adding a loading state to the publish button? we can have an isPublishing useState value that we set to true before saving the draft and false after publishing testimony. Then if isPublishing is true, we disable the publish button and change the text to "Loading..."
| <div> | ||
| <links.External href={url}> | ||
| Send copy to your legislators | ||
| </links.External> | ||
| </div> | ||
| <div> | ||
| <links.External href={url}> | ||
| Send copy to relevant committee | ||
| </links.External> | ||
| </div> |
There was a problem hiding this comment.
Should we show these if the user has not chosen legislators? Maybe a note to say "add your legislators in your profile to email them your testimony"
| const defaultContent = testimony && testimony.content ? testimony.content : defaultTestimony | ||
|
|
||
| const publishTestimony = async () => { | ||
| if (testimony.position == undefined || testimony.position == positionMessage) { return } |
There was a problem hiding this comment.
Consider adding a validation error message to the form in this case so the user can more easily tell why the form didn't submit
There was a problem hiding this comment.
Good idea. I changed the publish button to be "Select your support to publish" if they haven't chosen a position to explain why it doesn't submit.
|
One of the integration tests is changing due to the changes in useEditTestimony. We can disable this test for now by adding |
| } | ||
|
|
||
| const positionChosen = testimony.position != undefined && testimony.position != positionMessage |
There was a problem hiding this comment.
I think the second condition should be testimony.content !== positionMessage
There was a problem hiding this comment.
actually the original is correct. it is testing to make sure that the user has not re-chosen the default position, which is "Select my support..(required)" This would only happen if the user chooses a position such as "Endorse" and then re-selects the "Select my support..(required)" option.
I tried to disable the "Select my support..(required)" option, but then the menu defaults to this first enabled option "Endorse"
No description provided.