bootstrap refactoring #1439
Closed
bootstrap refactoring #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Removed this as it was part of a previous issue
Remove unnecessary comment
|
@sashamaryl deleted all js and css files, all tsx files use bootstrap, could you clarify on the component re-use again? Based on the code I'm seeing, a lot of the components being used seem to be customized (e.g. within the ForIndividualsCardContent component, you have customized components like WhyMapleCardContent and BenefitsCardContent). Since the components are different as per each card, wasn't sure where to start |
|
Thanks for the PR! This is no longer needed - we've finished the migration for these components. Going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a short summary of the changes, and a reference to the original issue using
#and the issue number, like #1REFACTOR: About Pages #1417
-converted files to tsx
-incorporated bootstrap in SupportMapleCardContent
-removed css file for SupportMapleCardContent
Screenshots
Steps to test/reproduce
@all-contributors please add @azheng1991 for refactoring contributions