Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap refactor profile page #1437

Merged

Conversation

sashamaryl
Copy link
Collaborator

@sashamaryl sashamaryl commented Feb 8, 2024

Summary

Refactor profile page to use bootstrap, remove css modules

Known Issues

There is no margin between the last page body card and the footer. This should be addressed in the card component.

start using a role check instead of the boolean isOrg in prep for having more types of profiles
refactor profile buttons and header:
   style to use bootstrap
   layout to combine browser and mobile with responsive add classes for adjusting tracking (letter-spacing)
Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2024 4:25pm

remove fluid from container and move banners outside container
correct src for profile icons in ProfileIcon
clarify comments
clean up imports
@mertbagt
Copy link
Collaborator

A few of the buttons have colors that are funky
OR
the figma's been update since I last saw these component and if so then ignore these comments

the [* Settings] button on the Edit Profile page has a transparent background-color, possibly should be white; the on hover colors look correct for that state

on the privacy settings modal, the Make Private button starts out background-color: red which transitions to white on hover
when the button is clicked is uses blue (white on hover) and then when clicked again, uses white (blue on hover)
the initial red should probably follow the white/blue theming?

again, if the design's been updated, then ignore all of this

none of this should be a blocker and can be addressed or ignored as needed in the future

@mertbagt mertbagt merged commit cc8174e into codeforboston:main Feb 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants