-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade next react #1385
Merged
sashamaryl
merged 23 commits into
codeforboston:main
from
sashamaryl:upgrade-next-react
Dec 26, 2023
Merged
Upgrade next react #1385
sashamaryl
merged 23 commits into
codeforboston:main
from
sashamaryl:upgrade-next-react
Dec 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
alexjball
added a commit
to alexjball/maple
that referenced
this pull request
Dec 26, 2023
The direbase-action docker container updated to firebase tools v13 and Node 18 2 weeks ago. Since our workflow used the `master` tag, it started using that new version in recent runs, which fails because our firebase functions require node 16. So we just need to use an older version of the image from last month for deploys to work. PR codeforboston#1385 updates to node 18, but this will allow us to fix the current prod deployment before then.
alexjball
approved these changes
Dec 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sasha! This helps with security, onboarding, performance, and making sure we can support the latest features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #783
upgrades to nextjs 14 and react 18
updates dependencies and resolves conflicts
also updates storybook and chromatic, old versions were incompatible
auto and manual migration for storybook.