Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusted facebook link on profiles #1251

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

timblais
Copy link
Collaborator

@timblais timblais commented Aug 9, 2023

Summary

Fixes the facebook link issue from #1069

PR #1077 added changes to standardize how social media links are stored in the db, but old code remained for the actual link to facebook that was linking to the linkedin value (which if blank defaulted back to the user/org profile)

Checklist

  • [ N/A] On the frontend, I've made my strings translate-able.
  • [ N/A] If I've added shared components, I've added a storybook story.
  • [ N/A] I've made pages responsive and look good on mobile.

Screenshots

Prod:
image

Dev:
image

Known issues

The code will append https://www.facebook.com/ with whatever is defined as the fb link in the db. Any orgs/profiles created before PR 1077 may be weird/may need to be manually updated

Steps to test/reproduce

For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.:

  1. Go to the org profile
  2. Hover over/click the link for fb
  3. confirm that the link is a valid fb link

@vercel
Copy link

vercel bot commented Aug 9, 2023

@timblais is attempting to deploy a commit to the Maple Testimony Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 1:12am

@mvictor55
Copy link
Collaborator

will re run the checks after oliver's commit

@mvictor55 mvictor55 merged commit c4da08b into codeforboston:main Aug 30, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants