nav mobile view #1227
Merged
nav mobile view #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@hshareef9 is attempting to deploy a commit to the Maple Testimony Team on Vercel. A member of the Team first needs to authorize it. |
sashamaryl
requested changes
Jul 17, 2023
sashamaryl
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#1220
changes to mobile view:
displays only tree as logo- does not get smaller
sign in button w/o text
profile icon without greeting
made added strings translatable for components with preexisting translations
Checklist
Screenshots
Before:
mapleNAV.mov
After:
Screen.Recording.2023-07-17.at.12.44.01.AM.mov
Known issues
Dropdown menu when expanded pushes logo in mobile view- this was already existing so not a new issue
created ticket #1226