Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a Senate/House toggle on the Map component #21

Closed
NONstiky opened this issue Jan 20, 2021 · 2 comments · Fixed by #36
Closed

Make a Senate/House toggle on the Map component #21

NONstiky opened this issue Jan 20, 2021 · 2 comments · Fixed by #36

Comments

@NONstiky
Copy link
Collaborator

No description provided.

@bhinebaugh
Copy link
Contributor

going to be borrowing from Brian's implementation for this https://github.com/bhrutledge/ma-legislature/blob/main/index.html

bhinebaugh added a commit to bhinebaugh/advocacy-maps that referenced this issue Jan 26, 2021
@bhrutledge
Copy link
Collaborator

Following up from a discussion with @bhinebaugh, I recommend "rebooting" Map.jsx with the code from https://github.com/bhrutledge/ma-legislature/, rather than trying to build on what's already there, which was based on https://github.com/actonmass/campaign-map. I spent a decent amount of time refactoring the actonmass code to support both chambers, and removed everything that was specific to that campaign.

Ideally, I think this would wait until @mvictor55 has a complete Google Sheet for one piece of legislation (i.e., ranking of support for both chambers), because that will impact how the data is loaded and transformed. However, in the interest of making progress, I think porting the ma-legislature code as-is would give a good base to build on. I'm optimistic that I could do it relatively quickly, but would happily let somebody else tackle it. If somebody else picks this up, I think familiarity with Leaflet is helpful, and I'm happy to review the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants