Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3.8.5 pipeline] Simplify post-process settings and fix fsr bug of PostProcess pipeline #17210

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

star-e
Copy link
Contributor

@star-e star-e commented Jun 24, 2024

Simplify pipeline usage: Use Post Process does not affect BuiltinPipeline anymore.
Revert fsr change, to fix regression problem on cyberpunk demo.

Changelog

  • revert fst pipeline layout name.
  • Remove camera.usePostProcess from BuiltinPipeline.

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@star-e star-e changed the title V3.8.5 pipeline [V3.8.5 pipeline] Simplify post-process settings and fix fsr bug of PostProcess pipeline Jun 24, 2024
@star-e
Copy link
Contributor Author

star-e commented Jun 24, 2024

@cocos-robot run test cases

Copy link

github-actions bot commented Jun 24, 2024

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -37226,11 +37226,10 @@
              * @zh 渲染管线状态更新的回调
              */
             onGlobalPipelineStateChanged?(): void;
         }
-        export function setEditorPipelineSettings(settings: PipelineSettings | null, camera: renderer.scene.Camera | null | undefined): void;
+        export function setEditorPipelineSettings(settings: PipelineSettings | null): void;
         export function getEditorPipelineSettings(): PipelineSettings | null;
-        export function getEditorPipelineCamera(): renderer.scene.Camera | null;
         export function forceResizeAllWindows(): void;
         export function defaultWindowResize(ppl: BasicPipeline, window: renderer.RenderWindow, width: number, height: number): void;
         export function dispatchResizeEvents(cameras: renderer.scene.Camera[], builder: PipelineBuilder, ppl: BasicPipeline): void;
     }

@star-e
Copy link
Contributor Author

star-e commented Jun 24, 2024

@cocos-robot run test cases

1 similar comment
@star-e
Copy link
Contributor Author

star-e commented Jun 26, 2024

@cocos-robot run test cases

Copy link

@star-e, Please check the result of run test cases:

Task Details

Copy link

@star-e, Please check the result of run test cases:

Task Details

@star-e star-e requested a review from minggo June 26, 2024 06:04
@star-e star-e merged commit 564d4f5 into cocos:v3.8.5 Jun 26, 2024
10 checks passed
@star-e star-e deleted the v3.8.5-pipeline branch June 26, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants