fixed issues 8940 #14808
Merged
fixed issues 8940 #14808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bofeng-song
reviewed
May 25, 2023
cocos2d/core/assets/CCAudioClip.js
Outdated
| @@ -127,6 +127,7 @@ var AudioClip = cc.Class({ | |||
| let self = this; | |||
| cc.assetManager.postLoadNative(this, function (err) { | |||
| self._loading = false; | |||
| self.loaded = true; | |||
There was a problem hiding this comment.
Need to check the value of err, if err has a value it means an error occurred, probably due to a problem with resource loading.
There was a problem hiding this comment.
Added code to check the err parameter
bofeng-song
approved these changes
May 25, 2023
bofeng-song
approved these changes
May 25, 2023
pandamicro
suggested changes
Jun 8, 2023
| @@ -78,7 +78,7 @@ var AudioClip = cc.Class({ | |||
| this._audio = value; | |||
| } | |||
| if (this._audio) { | |||
| this.loaded = true; | |||
| // this.loaded = true; | |||
| this.emit('load'); | |||
There was a problem hiding this comment.
Should delay load event to the callback too, also need to check whether this modification cause issue in web and mini game platforms
bofeng-song
approved these changes
Jul 2, 2024
minggo
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: 8940
This problem only occurs on mobile devices (currently only Android phones have this problem) because it takes longer to load Audio resources on mobile devices than on computers.
The problem is that the loaded state of audioClip cannot be set directly when setting _nativeAsset, but should be set in the execution callback after the native resource is actually loaded, otherwise the audio will not be played when you click play for the first time on the mobile device. The engine is modified as follows:
因为在手机设备上加载 Audio 资源所需要的时间比在电脑上来得长，所以此问题只有出现在手机设备上。
问题原因是 audioClip 的 loaded 状态不能在设置 _nativeAsset 时就被直接设置，而应该是在原生资源真正被加载完成后的执行回调里设置，否则会导致在手机设备（目前只有 Android 手机会有此问题）上第一次点击播放时无法播放音频。引擎修改方法如下：