Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uniformity check on chromium 108 for webgpu[DO NOT MERGE] #13180

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

hana-alice
Copy link
Contributor

Re: #
chromium 108 TINT has strenthen the validation for uniformity control flow.

Changelog

  • reduce branch only WEBGPU_WASM_DAWN is defined.

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions
Copy link

Interface Check Report

This pull request does not change any public interfaces !

@github-actions
Copy link

@hana-alice, Please check the result of run test cases:

Task Details

Platform build runned result crashScene FailScene
WebDesktop_release PASS PASS PASS NA
WebMobile_release PASS PASS PASS NA
Win32_release PASS PASS PASS NA
Android_debug PASS PASS FAIL NA Hexa

@github-actions
Copy link

@hana-alice, Please check the result of run test cases:

Task Details

Platform build runned result crashScene FailScene
ios_release PASS PASS PASS NA
Mac_debug PASS PASS PASS NA
WebMobile_debug PASS PASS PASS NA

@github-actions
Copy link

@hana-alice, Please check the result of run test cases:

Task Details

Platform build runned result crashScene FailScene
ios_release PASS PASS PASS NA
Mac_debug PASS PASS PASS NA
WebMobile_debug PASS PASS FAIL sprite-Altas

@github-actions
Copy link

@hana-alice, Please check the result of run test cases:

Task Details

Platform build runned result crashScene FailScene
WebDesktop_release PASS PASS PASS NA
WebMobile_release PASS PASS PASS NA
Win32_release PASS PASS PASS NA
Android_debug PASS PASS FAIL NA Hexa

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

@hana-alice, Please check the result of run test cases:

Task Details

Platform build runned result crashScene FailScene
ios_release PASS PASS PASS NA
Mac_debug PASS PASS PASS NA
WebMobile_debug PASS PASS PASS NA

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

@hana-alice, Please check the result of run test cases:

Task Details

Platform build runned result crashScene FailScene
WebDesktop_release PASS PASS PASS NA
WebMobile_release PASS PASS PASS NA
Win32_release PASS PASS PASS NA
Android_debug PASS PASS PASS NA

@hana-alice
Copy link
Contributor Author

Chromium 109 has revert its validation, this is not an urgent requirement on shader now, so hang on to run more test case. Any issue will be updated.

@hana-alice hana-alice marked this pull request as draft November 25, 2022 02:51
@hana-alice hana-alice changed the title fix uniformity check on chromium 108 for webgpu fix uniformity check on chromium 108 for webgpu[DO NOT MERGE] May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants