Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create project proposal for CoreDNS #9

Merged
merged 15 commits into from
Mar 2, 2017
Merged

Create project proposal for CoreDNS #9

merged 15 commits into from
Mar 2, 2017

Conversation

caniszczyk
Copy link
Contributor

Initial draft of the project proposal for CoreDNS

https://github.com/miekg/coredns


*Issue tracker*: https://github.com/miekg/coredns

*Website*: https://miek.nl/tags/coredns/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caniszczyk
Copy link
Contributor Author

Thanks @miekg, updated


*Description*

CoreDNS is a fast, flexible DNS server that is designed to be performant with a flexible implementation. This flexibility allows CoreDNS to be easily extended to support various data sources and to implement rich DNS service behaviors. For example, response caching, query rewrite, load-balancing, zone transfer and signing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

behaviors: for example,

@jonboulle
Copy link
Contributor

jonboulle commented Aug 19, 2016

Mostly LGTM; the big outstanding question to me is the caddy relationship, I'd like to be a bit clearer here about the future plans/implications there.

@jonboulle
Copy link
Contributor

Also, could you add a note about existing community size/adoption/etc?

miekg and others added 3 commits August 19, 2016 07:33
Explain a little what SkyDNS is and what it lacks and how the dependency
on Caddy works.
@miekg
Copy link
Contributor

miekg commented Aug 20, 2016

Send two PRs today, I think they should address all of Jon's comments.

Also Jon: Hi! And thanks for sponsering @jonboulle :-) Feel free to say if this isn't sufficient yet.

@mrichmon anything you want to add?

@mrichmon
Copy link
Contributor

Opened a PR to add miekg to the initial committers list.

Otherwise, this looks like a cut and paste from the Google Document that I wrote. So I'm good with this. Caddy is essentially just another framework dependency.

@jonboulle
Copy link
Contributor

I put up #14 but it's mostly nits/grammar cleanup. Overall this LGTM!

various minor changes to CoreDNS proposal
@jonboulle
Copy link
Contributor

👍

@caniszczyk
Copy link
Contributor Author

If this is ready to vote on @jonboulle I'd recommend doing a +1 here, would love to see if we can use PullApprove to automatically count the minimum 6 +1 votes before we merge in

@johnbelamaric
Copy link
Contributor

Please note that CoreDNS is being proposed as an inception project per https://github.com/cncf/toc/blob/master/process/graduation_criteria.adoc.

@jonboulle
Copy link
Contributor

@johnbelamaric mind adding that to the doc? c.f. #27

@johnbelamaric
Copy link
Contributor

no problem

Add the preferred maturity level (inception). Update based on community
and Kubernetes changes since original.
@johnbelamaric
Copy link
Contributor

In PR #28

Copy link
Contributor

@jonboulle jonboulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


*Existing community*: The community is small, but growing. On GitHub, we have 50+ forks, 550+ stars, and 24 contributors (5 with merge privileges).
Current number of Twitter followers is 180+. By aligning ourselves with the Caddy community, we hope to leverage Caddy's
popularity for CoreDNS. By positioning CoreDNS as a better SkyDNS, we hope to entice existing users of SkyDNS to migrate to and embrace CoreDNS.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth calling out if there is a migration path/guidance for existing SkyDNS users


Go dependencies:

* Go package: mholt/caddy (ASLV2 https://github.com/mholt/caddy/blob/master/LICENSE.txt)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort this list? appears somewhat random

*Comparison with KubeDNS*:

The incumbent DNS service for Kubernetes, “kubedns”, consists of three components:
* kube-dns which uses SkyDNS as a library provides the DNS service based on the Kubernetes API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kube-dns, which uses SkyDNS as a library, provides ...

CoreDNS is coming in as an inception level project.

Signed-off-by: Chris Aniszczyk <[email protected]>
@@ -16,6 +16,8 @@ used in cloud deployments, but lacks the flexibility of CoreDNS.

*License*: Apache License v2.0

*Maturity Level*: Inception
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preferred Maturity Level is above, should it be removed?

@johnbelamaric
Copy link
Contributor

👍

@jonboulle
Copy link
Contributor

jonboulle commented Feb 3, 2017

👍

Approved with PullApprove

@caniszczyk caniszczyk changed the title Create initial project proposal for CoreDNS Create project proposal for CoreDNS Mar 2, 2017
@caniszczyk caniszczyk merged commit 1a50d0e into master Mar 2, 2017
@caniszczyk caniszczyk deleted the coredns-proposal branch March 2, 2017 16:29
@caniszczyk
Copy link
Contributor Author

CoreDNS has been accepted as an inception level project, welcome and thanks for all the iterations on the proposal: https://lists.cncf.io/pipermail/cncf-toc/2017-March/000680.html

amye pushed a commit that referenced this pull request Dec 19, 2023
Signed-off-by: David Hirsch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants