-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create project proposal for CoreDNS #9
Conversation
proposals/coredns.adoc
Outdated
|
||
*Issue tracker*: https://github.com/miekg/coredns | ||
|
||
*Website*: https://miek.nl/tags/coredns/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Chris Aniszczyk <[email protected]>
Thanks @miekg, updated |
proposals/coredns.adoc
Outdated
|
||
*Description* | ||
|
||
CoreDNS is a fast, flexible DNS server that is designed to be performant with a flexible implementation. This flexibility allows CoreDNS to be easily extended to support various data sources and to implement rich DNS service behaviors. For example, response caching, query rewrite, load-balancing, zone transfer and signing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
behaviors: for example,
Mostly LGTM; the big outstanding question to me is the caddy relationship, I'd like to be a bit clearer here about the future plans/implications there. |
Also, could you add a note about existing community size/adoption/etc? |
Explain a little what SkyDNS is and what it lacks and how the dependency on Caddy works.
Add text about Caddy and SkyDNS
Send two PRs today, I think they should address all of Jon's comments. Also Jon: Hi! And thanks for sponsering @jonboulle :-) Feel free to say if this isn't sufficient yet. @mrichmon anything you want to add? |
Address Jon's comments
Opened a PR to add miekg to the initial committers list. Otherwise, this looks like a cut and paste from the Google Document that I wrote. So I'm good with this. Caddy is essentially just another framework dependency. |
Add miekg to initial committers list
Better text from michael
I put up #14 but it's mostly nits/grammar cleanup. Overall this LGTM! |
various minor changes to CoreDNS proposal
👍 |
If this is ready to vote on @jonboulle I'd recommend doing a +1 here, would love to see if we can use PullApprove to automatically count the minimum 6 +1 votes before we merge in |
Please note that CoreDNS is being proposed as an inception project per https://github.com/cncf/toc/blob/master/process/graduation_criteria.adoc. |
@johnbelamaric mind adding that to the doc? c.f. #27 |
no problem |
Add the preferred maturity level (inception). Update based on community and Kubernetes changes since original.
In PR #28 |
Update for Redux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
*Existing community*: The community is small, but growing. On GitHub, we have 50+ forks, 550+ stars, and 24 contributors (5 with merge privileges). | ||
Current number of Twitter followers is 180+. By aligning ourselves with the Caddy community, we hope to leverage Caddy's | ||
popularity for CoreDNS. By positioning CoreDNS as a better SkyDNS, we hope to entice existing users of SkyDNS to migrate to and embrace CoreDNS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth calling out if there is a migration path/guidance for existing SkyDNS users
|
||
Go dependencies: | ||
|
||
* Go package: mholt/caddy (ASLV2 https://github.com/mholt/caddy/blob/master/LICENSE.txt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort this list? appears somewhat random
*Comparison with KubeDNS*: | ||
|
||
The incumbent DNS service for Kubernetes, “kubedns”, consists of three components: | ||
* kube-dns which uses SkyDNS as a library provides the DNS service based on the Kubernetes API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kube-dns, which uses SkyDNS as a library, provides ...
CoreDNS is coming in as an inception level project. Signed-off-by: Chris Aniszczyk <[email protected]>
proposals/coredns.adoc
Outdated
@@ -16,6 +16,8 @@ used in cloud deployments, but lacks the flexibility of CoreDNS. | |||
|
|||
*License*: Apache License v2.0 | |||
|
|||
*Maturity Level*: Inception |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preferred Maturity Level is above, should it be removed?
👍 |
CoreDNS has been accepted as an inception level project, welcome and thanks for all the iterations on the proposal: https://lists.cncf.io/pipermail/cncf-toc/2017-March/000680.html |
Signed-off-by: David Hirsch <[email protected]>
Initial draft of the project proposal for CoreDNS
https://github.com/miekg/coredns