Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Jon's comments #11

Merged
merged 1 commit into from
Aug 20, 2016
Merged

Address Jon's comments #11

merged 1 commit into from
Aug 20, 2016

Conversation

miekg
Copy link
Contributor

@miekg miekg commented Aug 20, 2016

Address more (all?) of Jon's comments.

@mrichmon
Copy link
Contributor

Changes look good.

Not sure about the phrasing of a "hard dependency" on Caddy. The new coredns.go partly addresses this. I view Caddy as a framework that coredns uses in two ways:

  • much of the coredns code plugs into the framework to add dns behavior.
  • coredns provides a wrapper around the framework to provide a dns-tuned command-line interface.
    So this feels like using a library/framework.

@caniszczyk caniszczyk merged commit e408ee6 into cncf:coredns-proposal Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants