Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove mentions of high contrast header from descriptions #2389

Merged
merged 2 commits into from
Jul 1, 2024
Merged

chore: Remove mentions of high contrast header from descriptions #2389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bdd5e9
chore: Remove mentions of high contrast header from descriptions
connorlanigan Jun 18, 2024
34adf64
Update documenter snapshot
connorlanigan Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/__tests__/__snapshots__/documenter.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4215,8 +4215,7 @@ It's also used for connecting \`items\` and \`selectedItems\` values when they d
"defaultValue": "'container'",
"description": "Specify a cards variant with one of the following:
* \`container\` - Use this variant to have the cards displayed as a container.
* \`full-page\` – Use this variant when cards are the entire content of a page. Full page variants
implement the high contrast header and content behavior automatically.",
* \`full-page\` – Use this variant when cards are the entire content of a page.",
"inlineType": Object {
"name": "",
"type": "union",
Expand Down Expand Up @@ -14360,8 +14359,7 @@ It's also used to connect \`items\` and \`selectedItems\` or \`expandableRows.ex
**Deprecated**, replaced by \`borderless\` and \`container\`.
* \`stacked\` - Use this variant adjacent to other stacked containers (such as a container,
table).
* \`full-page\` – Use this variant when the table is the entire content of a page. Full page variants
implement the high contrast header and content behavior automatically.",
* \`full-page\` – Use this variant when the table is the entire content of a page.",
"inlineType": Object {
"name": "TableProps.Variant",
"type": "union",
Expand Down
3 changes: 1 addition & 2 deletions src/cards/interfaces.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,7 @@ export interface CardsProps<T = any> extends BaseComponentProps {
/**
* Specify a cards variant with one of the following:
* * `container` - Use this variant to have the cards displayed as a container.
* * `full-page` – Use this variant when cards are the entire content of a page. Full page variants
* implement the high contrast header and content behavior automatically.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't content behaviour still controlled by the variant?

* * `full-page` – Use this variant when cards are the entire content of a page.
* @visualrefresh `full-page` variant
*/
variant?: 'container' | 'full-page';
Expand Down
3 changes: 1 addition & 2 deletions src/table/interfaces.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,7 @@ export interface TableProps<T = any> extends BaseComponentProps {
* **Deprecated**, replaced by `borderless` and `container`.
* * `stacked` - Use this variant adjacent to other stacked containers (such as a container,
* table).
* * `full-page` – Use this variant when the table is the entire content of a page. Full page variants
* implement the high contrast header and content behavior automatically.
* * `full-page` – Use this variant when the table is the entire content of a page.
* @visualrefresh `embedded`, `stacked`, and `full-page` variants
*/
variant?: TableProps.Variant;
Expand Down
Loading