chore: Remove mentions of high contrast header from descriptions #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdhalees
reviewed
Jun 18, 2024
| @@ -206,8 +206,7 @@ export interface CardsProps<T = any> extends BaseComponentProps { | |||
| /** | |||
| * Specify a cards variant with one of the following: | |||
| * * `container` - Use this variant to have the cards displayed as a container. | |||
| * * `full-page` – Use this variant when cards are the entire content of a page. Full page variants | |||
| * implement the high contrast header and content behavior automatically. | |||
There was a problem hiding this comment.
isn't content behaviour still controlled by the variant?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2389 +/- ##
==========================================
+ Coverage 95.49% 95.62% +0.12%
==========================================
Files 708 720 +12
Lines 18887 19163 +276
Branches 5998 6438 +440
==========================================
+ Hits 18037 18324 +287
+ Misses 842 785 -57
- Partials 8 54 +46 ☔ View full report in Codecov by Sentry. |
abdhalees
previously approved these changes
Jun 21, 2024
abdhalees
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were two descriptions that mention the high-contrast header for Cards and Table, which have been removed.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.