Skip to content
This repository has been archived by the owner on Mar 16, 2022. It is now read-only.

whitelist specific keys to prevent re-rendering search results #56

Merged
merged 13 commits into from
Jan 27, 2016
Merged

whitelist specific keys to prevent re-rendering search results #56

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0421770
whilelisted specific keyevents from unnecessarily re-rendering the se…
egladman Jan 9, 2016
b44d818
debounce keyup event
egladman Jan 9, 2016
b230038
reduced the timeout from 250ms to 100ms
egladman Jan 9, 2016
3bd2580
added 'enter' key to whitelist
egladman Jan 9, 2016
27ca02f
added 'capslock' key to whitelist
egladman Jan 9, 2016
2ed5e18
added 'mod' key to whitelist
egladman Jan 9, 2016
087c89b
added 'shift' key to whitelist
egladman Jan 9, 2016
733b20b
reverted commit #0421770 since I wasn't aware the json was loaded async
egladman Jan 10, 2016
4a3daa3
compiled lastest builds
egladman Jan 10, 2016
56a25b1
added missing semicolons
egladman Jan 16, 2016
184855f
updated build to reflect recent changes
egladman Jan 16, 2016
0c0ed5f
simplified conditional upon request
egladman Jan 27, 2016
6ad65dd
updated build to reflect latest changes
egladman Jan 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added missing semicolons
  • Loading branch information
@egladman
egladman committed Jan 16, 2016
commit 56a25b11b9190aa1a8f234b085f1c5eab6287aee
4 changes: 2 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@

// if the key pressed isn't one of the following whitelisted codes precede
if( eval(keyCodes) ){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eval can be harmful.

emptyResultsContainer()
emptyResultsContainer();
if( e.target.value.length > 0 ){
render( repository.search(e.target.value) )
render( repository.search(e.target.value) );
}
}

Expand Down