This repository has been archived by the owner on Mar 16, 2022. It is now read-only.
whitelist specific keys to prevent re-rendering search results #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if( eval(keyCodes) ){ | ||
| emptyResultsContainer() | ||
| if( e.target.value.length > 0 ){ | ||
| render( repository.search(e.target.value) ) |
|
This is really great, thank you so much! |
|
Any updates? |
|
Hello! like: |
|
Nice suggestion. I wish I thought of that myself. |
christian-fei
added a commit
that referenced
this pull request
Jan 27, 2016
whitelist specific keys to prevent re-rendering search results
|
thank you very much! you rock 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #55.
This whitelists the following keys:
event.whichis technically deprecated, however it still is the 'go-to' means of detecting keyevents untilKeyboardEvent.codegains support. Even jQuery still usesevent.which.If your curious how these changes effect the scripts behavior, checkout this site where I'm using this patched version.
Thanks for creating and maintaining this project