fix(cli/js/web): IPv6 hostname should be compressed (denoland#6772)

chatch · Jul 16, 2020 · d60f9c2 · d60f9c2
1 parent de34166
commit d60f9c2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/cli/js/web/url.ts b/cli/js/web/url.ts
@@ -565,7 +565,8 @@ function encodeHostname(s: string, isSpecial = true): string {
  if (!s.match(/^\[[0-9A-Fa-f.:]{2,}\]$/)) {
  throw new TypeError("Invalid hostname.");
  }
- return s.toLowerCase();
+ // IPv6 address compress
+ return s.toLowerCase().replace(/\b:?(?:0+:?){2,}/, "::");
  }
 
  let result = s;

diff --git a/cli/tests/unit/url_test.ts b/cli/tests/unit/url_test.ts
@@ -44,6 +44,8 @@ unitTest(function urlHostnameParsing(): void {
  assertEquals(new URL("http:https://[::1]").hostname, "[::1]");
  assertEquals(new URL("file:https://[::1]").hostname, "[::1]");
  assertEquals(new URL("abcd:https://[::1]").hostname, "[::1]");
+ assertEquals(new URL("http:https://[0:f:0:0:f:f:0:0]").hostname, "[0:f::f:f:0:0]");
+ assertEquals(new URL("http:https://[0:0:5:6:7:8]").hostname, "[::5:6:7:8]");
 
  // Forbidden host code point.
  assertThrows(() => new URL("http:https:// a"), TypeError, "Invalid URL.");