Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/js/web): IPv6 hostname should be compressed #6772

Merged
merged 1 commit into from
Jul 16, 2020
Merged

fix(cli/js/web): IPv6 hostname should be compressed #6772

merged 1 commit into from
Jul 16, 2020

Conversation

JohannLai
Copy link
Contributor

IPv6 hostname is compressed in the browser：

new URL("http:https://[0:f:0:0:f:f:0:0]").hostname
// "[0:f::f:f:0:0]"

So，IPv6 hostname should be compressed in Deno.

@CLAassistant
Copy link

CLAassistant commented Jul 16, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JohannLai JohannLai changed the title fix(cli/js/web): IPv6 hostname should be compressed [WIP]fix(cli/js/web): IPv6 hostname should be compressed Jul 16, 2020
@JohannLai JohannLai changed the title [WIP]fix(cli/js/web): IPv6 hostname should be compressed fix(cli/js/web): IPv6 hostname should be compressed Jul 16, 2020
ry
ry approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - LGTM

@ry ry merged commit d60f9c2 into denoland:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JohannLai @CLAassistant @ry