[Docker] Pin fastapi in a separate requirements file (ray-project#2…

…9441) Signed-off-by: Amog Kamsetty [email protected] The ML Docker image does not pick up changes in requirements.txt due to a bug. This is being fixed here ray-project#29375. We pin fastapi in a separate file as a stopgap solution to immediately resolve ray-project#29396
charleslai2000 · Oct 19, 2022 · 47594dd · 47594dd
1 parent 4bcfb80
commit 47594dd
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/docker/ray-ml/Dockerfile b/docker/ray-ml/Dockerfile
@@ -10,6 +10,7 @@ COPY requirements_rllib.txt ./
 COPY requirements_tune.txt ./requirements_tune.txt
 COPY requirements_train.txt ./
 COPY requirements_upstream.txt ./
+COPY requirements_extra.txt ./
 
 RUN sudo apt-key adv --fetch-keys https://developer.download.nvidia.com/compute/cuda/repos/ubuntu1804/x86_64/3bf863cc.pub
 RUN sudo apt-key adv --fetch-keys https://developer.download.nvidia.com/compute/machine-learning/repos/ubuntu1804/x86_64/7fa2af80.pub
@@ -29,6 +30,7 @@ RUN sudo apt-get update \
  -r requirements_train.txt \
  -r requirements_tune.txt \
  -r requirements_upstream.txt \
+ -r requirements_extra.txt \
  # explicitly install (overwrite) pytorch with CUDA support
  && $HOME/anaconda3/bin/pip --no-cache-dir install -U \
  -r requirements_ml_docker.txt \

diff --git a/python/requirements/ml/requirements_rllib.txt b/python/requirements/ml/requirements_rllib.txt
@@ -34,7 +34,7 @@ higher==0.2.1
 pyglet==1.5.15
 imageio-ffmpeg==0.4.5
 # Ray Serve example
-starlette==0.18.0
+starlette==0.17.1
 # ONNX
 onnx==1.9.0
 onnxruntime==1.9.0

diff --git a/python/requirements/requirements_extra.txt b/python/requirements/requirements_extra.txt
@@ -0,0 +1,3 @@
+# TODO: Remove this file and move to requirements.txt once https://github.com/ray-project/ray/pull/29375 is merged.
+
+fastapi==0.75.0
diff --git a/release/serve_tests/gpu_app_config.yaml b/release/serve_tests/gpu_app_config.yaml
@@ -7,10 +7,6 @@ debian_packages:
 python:
  pip_packages:
  - "validators"
- # ray-ml image is not able to reflect the requirements.txt
- # So install the starlette here temporary.
- # https://github.com/ray-project/ray/issues/29396
- - starlette==0.20.4
  conda_packages: []
 
 post_build_cmds: