[Docker] Pin fastapi in a separate requirements file
#29441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amog Kamsetty <[email protected]>
krfricke
reviewed
Oct 18, 2022
| @@ -0,0 +1,3 @@ | |||
| # TODO: Remove this file and move to requirements.txt once https://github.com/ray-project/ray/pull/29375 is merged. | |||
|
|
|||
| fastapi==0.84.0 | |||
There was a problem hiding this comment.
Suggested change
| fastapi==0.84.0 | |
| fastapi==0.84.0 | |
| protobuf==3.20.1 |
krfricke
approved these changes
Oct 18, 2022
sihanwang41
requested changes
Oct 18, 2022
There was a problem hiding this comment.
This will break the serve release test until https://github.com/ray-project/ray/blob/master/release/serve_tests/gpu_app_config.yaml#L13 remove.
Signed-off-by: Amog Kamsetty <[email protected]>
Signed-off-by: Amog Kamsetty <[email protected]>
sihanwang41
reviewed
Oct 19, 2022
Signed-off-by: Amog Kamsetty <[email protected]>
sihanwang41
approved these changes
Oct 19, 2022
amogkam
added a commit
to amogkam/ray
that referenced
this pull request
Oct 19, 2022
…9441) Signed-off-by: Amog Kamsetty [email protected] The ML Docker image does not pick up changes in requirements.txt due to a bug. This is being fixed here ray-project#29375. We pin fastapi in a separate file as a stopgap solution to immediately resolve ray-project#29396
xcharleslin
pushed a commit
that referenced
this pull request
Oct 21, 2022
Signed-off-by: Amog Kamsetty [email protected] The ML Docker image does not pick up changes in requirements.txt due to a bug. This is being fixed here #29375. We pin fastapi in a separate file as a stopgap solution to immediately resolve #29396 Signed-off-by: Xiayue Charles Lin <[email protected]>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…9441) Signed-off-by: Amog Kamsetty [email protected] The ML Docker image does not pick up changes in requirements.txt due to a bug. This is being fixed here ray-project#29375. We pin fastapi in a separate file as a stopgap solution to immediately resolve ray-project#29396 Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amog Kamsetty [email protected]
The ML Docker image does not pick up changes in
requirements.txtdue to a bug. This is being fixed here #29375.We pin
fastapiin a separate file as a stopgap solution to immediately resolve #29396Closes #29396
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.