Don't remove redundancy twice for planar V-rep (JuliaPolyhedra#261)

chachaleo · Jun 19, 2021 · 31f51a2 · 31f51a2
1 parent 3342c44
commit 31f51a2
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/src/redundancy.jl b/src/redundancy.jl
@@ -120,19 +120,20 @@ function removevredundancy!(p::Polyhedron; strongly=false, planar=true)
  vredundancy(p) == NO_REDUNDANCY && return
  if fulldim(p) == 2 && !strongly && planar
  setvrep!(p, planar_hull(vrep(p)), NO_REDUNDANCY)
- end
- solver = _solver_warn(p, true, strongly)
- if solver === nothing
- detecthlinearity!(p)
- detectvlinearity!(p)
- nonred = removevredundancy(vrep(p), hrep(p), strongly=strongly)
  else
- detectvlinearity!(p)
- nonred = removevredundancy(vrep(p), solver)
+ solver = _solver_warn(p, true, strongly)
+ if solver === nothing
+ detecthlinearity!(p)
+ detectvlinearity!(p)
+ nonred = removevredundancy(vrep(p), hrep(p), strongly=strongly)
+ else
+ detectvlinearity!(p)
+ nonred = removevredundancy(vrep(p), solver)
+ end
+ # If `strongly` then we only remove strongly redundant elements
+ # henwe we cannot say that the redundancy is `NO_REDUNDANCY`.
+ setvrep!(p, nonred, strongly ? LINEARITY_DETECTED : NO_REDUNDANCY)
  end
- # If `strongly` then we only remove strongly redundant elements
- # henwe we cannot say that the redundancy is `NO_REDUNDANCY`.
- setvrep!(p, nonred, strongly ? LINEARITY_DETECTED : NO_REDUNDANCY)
 end
 
 function _redundant_indices(rep::Representation, model::MOI.ModelLike, T::Type,