Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove redundancy twice for planar V-rep #261

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Conversation

blegat
Copy link
Member

@blegat blegat commented Jun 18, 2021

We already remove the redundancy with planar_hull, no need for the second part of course...

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #261 (acf18a4) into master (3342c44) will decrease coverage by 0.09%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
- Coverage   78.18%   78.08%   -0.10%     
==========================================
  Files          39       39              
  Lines        3213     3213              
==========================================
- Hits         2512     2509       -3     
- Misses        701      704       +3     
Impacted Files Coverage Δ
src/redundancy.jl 90.95% <75.00%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3342c44...acf18a4. Read the comment docs.

@blegat blegat merged commit 31f51a2 into master Jun 19, 2021
@blegat blegat deleted the bl/planar_red branch September 20, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant