Add urlencoding to the colon in the magiclink url #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the great package @cesargb, we have been using it with great success! 馃檪
We have recently encountered an issue where certain email security products (Barracuda Sentinel for example) are invalidating the links by stripping out the
:and everything after it, which means our links are missing the token entirely.I believe if we were to
urlencode()the separator the issue would no longer occur. 馃It should be safe to do as Laravel will urldecode any route parameters, which would transform the
%3Ato:as before.I've been running the changes on a local branch and i haven't noticed any issues. 馃憤
Build timing out, but the tests are passing locally: