Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add urlencoding to the colon in the magiclink url #102

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Add urlencoding to the colon in the magiclink url #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc68139
urlencode the colon
jamesdb Sep 11, 2023
050a627
update ConfigTest getTokenFromUrl to account for urlencoded colon
jamesdb Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/MagicLink.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,10 @@ public function setActionAttribute($value)
public function getUrlAttribute()
{
return url(sprintf(
'%s/%s:%s',
'%s/%s%s%s',
config('magiclink.url.validate_path', 'magiclink'),
$this->id,
urlencode(':'),
$this->token
));
}
Expand Down
2 changes: 1 addition & 1 deletion tests/ConfigTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function test_custom_token_length_bigger_than_max_value()

protected function getTokenFromUrl($url)
{
$parts = explode(':', $url);
$parts = explode(urlencode(':'), $url);

return end($parts);
}
Expand Down