tunnel: stop vpn adapter when another app takes over the vpn

[SaadAhmedGit]

fixes: #1545

This small change fixes the issue mentioned in the referenced issue. When another app takes over the VPN, onRevoke() method of the VpnService() is called which wasn't overriden to call stopVpnAdapter() which closes the tunnel.

Overriding onRevoke() to call stopVpnAdapter() ensures the tunnel is closed gracefully when another app starts the VPN.

[ignoramous]

Access to the variable vpnAdapter isn't synchronised, and so the check for vpnAdapter == null in the io coroutine is suspect.

Anyhow, thanks for the fix. I'll tag Hussain for review.

[SaadAhmedGit]

Access to the variable vpnAdapter isn't synchronised, and so the check for vpnAdapter == null in the io coroutine is suspect.

But super.onRevoke() only calls stopself() which doesn't use vpnAdapter. Even in signalStopService(), stopSelf() doesn't wait for stopVpnAdapter() to finish.

rethink-app/app/src/main/java/com/celzero/bravedns/service/BraveVPNService.kt

Lines 1926 to 1931 in 26bb94a

	fun signalStopService(userInitiated: Boolean = true) {
	if (!userInitiated) notifyUserOnVpnFailure()
	stopVpnAdapter()
	stopSelf()
	Logger.i(LOG_TAG_VPN, "stopped vpn adapter and vpn service")
	}

[ignoramous]

vpnAdapter == null check is problematic regardless of what calls what, since one coroutine setting vpnAdapter to null will not be known to another coroutine unless there is a lock/serialisation (via Volatile).

Don't worry about it too much, we'll take a look at it as a separate issue.

[SaadAhmedGit]

Closing because already fixed.

Reference

[hussainmohd-a]

@SaadAhmedGit Thank you!!