-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wireguard Bug] - Listen port isn't released when another VPN app attempts to start a VPN on the same port #1545
Comments
You're running WireGuard in Advanced mode? Rethink does not respect port number in Advanced mode (chooses at random).
That's weird. Rethink auto-stops the WireGuard tunnel listening on the conflicting port? In the UI, is it shown as active or inactive? |
In simple mode (adding this to issue description now)
It's showing as inactive |
Okay, we found the bug and have fixed it. Thanks! network engine ( rethink-app/app/src/main/java/com/celzero/bravedns/service/BraveVPNService.kt Lines 1926 to 1931 in 72fc90e
Moving |
Where can I see the commit for that? If there isn't, can I make the PR?
Yes it works. I have also fixed the issue by overriding |
We haven't upstreamed it yet. It is in our local fork. |
App version: v0.5.5n-14-g72fc90ec (fdroid)
Commit: 72fc90ec492f8289c58f4ff1d247472815ede9dc
If another VPN app uses the same listen port for wireguard and attempts to start a VPN when rethink's proxy is running, rethink stops the vpn but the port isn't released.
Then when you try to start rethink's proxy again, it gives the following error in a toast and logcat:
Here are the detailed steps to reproduce this with wireguard official app as the other VPN client.
(I couldn't reproduce it a 100% of the times but I am positive that it works most of the times)
51820
.Reopening the app fixes this issue.
I also observed that after step 4, logcat kept logging wireguard-go (GoLog) errors even though VPN was being shown as stopped in the rethink app.
The text was updated successfully, but these errors were encountered: