Deprecate the var.aws_zone and read it based on the given runner subnet #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
|
@kayma-hl thanks will check the PR later this week. |
npalm
reviewed
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The var.aws_zone parameter for the runner is not needed. We get the runner subnet which implies the availablity_zone.
The variable is now deprecated. It can be removed in the next major release (see #235). As module documentation is created automatically, no changes required. The examples are still valid and didn't mention the aws_zone variable.
Verification was done in the Hapag-Lloyd environment which uses this module in version 4.18.0 (docker+machine and spot instances).
Closes #232