Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does aws_zone has to match the subnet availability zone? #232

Closed
ghost opened this issue Jun 29, 2020 · 1 comment · Fixed by #236
Closed

Does aws_zone has to match the subnet availability zone? #232

ghost opened this issue Jun 29, 2020 · 1 comment · Fixed by #236

Comments

@ghost
Copy link

ghost commented Jun 29, 2020

Hi,

by accident I set the aws_zone to "b" but used a subnet_id_runners from availability zone eu-central-1a. As a result no runner was created. So if both variables are related I propose to remove the aws_zone variable and read the availability zone of the subnet via

data aws_subnet runners { id = var.subnet_id_runners }

Best regards
Matthias Kay
Hapag-Lloyd AG

@npalm
Copy link
Collaborator

npalm commented Jul 5, 2020

@kayma-hl I am not complete sure why we have splitted those two variables. I doubled checked the docker machine docs for EC2 (https://docs.docker.com/machine/drivers/aws/) and it seems we really have to set the zone paramters. Would you like to propose a PR to replace the logic by a lookup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant