Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add tests commit type #240

Merged
merged 8 commits into from
Feb 14, 2018
Merged

tests: add tests commit type #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6718a35
add bootstrap script to run yarn
manjula-dube Feb 10, 2018
b19ce22
chore: refactor the code
manjula-dube Feb 10, 2018
2eaccc7
docs: add bootstrap script description
manjula-dube Feb 10, 2018
4e5988e
docs: text change for bootstrap script
manjula-dube Feb 10, 2018
d5d679e
tests : add tests as commit type
manjula-dube Feb 10, 2018
87590e1
docs: add tests commit type
manjula-dube Feb 10, 2018
88b5a69
docs: add test in contributing.md and spell check
manjula-dube Feb 12, 2018
8f000bd
remove tests since we have test
manjula-dube Feb 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ You can learn how from this *free* series [How to Contribute to an Open Source P
* `BREAKING`: for changes that break current versiong usage, e.g. remove withTheme
* `docs`: changes into documentation, e.g. add usage example for Button
* `chore`: tooling changes, e.g. change circle ci config
* `test`: for testcases, eg unit, snapshot testing

3. We use `flow`, `eslint` and `prettier`. Be sure that `npm run flow` and `npm run lint -- --fix` give no errors.

Expand All @@ -39,7 +40,7 @@ You can learn how from this *free* series [How to Contribute to an Open Source P

5. In case of doubts, check out the current code. For example, we use the prop `icon` not `iconName`.

6. You can run `yarn run bootstrap` which will install all the dependecies in example & docs folder respectively.
6. You can run `yarn run bootstrap` which will install all the dependencies in example & docs folder respectively.

## Running the example

Expand Down
2 changes: 1 addition & 1 deletion scripts/validate-commit-message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const TYPES = {
test: true,
chore: true,
revert: true,
breaking: true,
breaking: true
};

function printError(...args) {
Expand Down