tests: add tests commit type #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @manjula91, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
satya164
previously requested changes
Feb 12, 2018
scripts/validate-commit-message.js
Outdated
| @@ -16,6 +16,7 @@ const TYPES = { | |||
| chore: true, | |||
| revert: true, | |||
| breaking: true, | |||
| tests: true | |||
There was a problem hiding this comment.
Hey, we already have test above, so we don't need it
|
yo cool i dint notice may be we should add it to the contributing.md as
well ;)
…On Mon, Feb 12, 2018 at 8:28 PM, Satyajit Sahoo ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In scripts/validate-commit-message.js
<#240 (comment)>
:
> @@ -16,6 +16,7 @@ const TYPES = {
chore: true,
revert: true,
breaking: true,
+ tests: true
Hey, we already have test above, so we don't need it
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#240 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHe4IcL7PWJIorvdBj7w54j30RUkN2hfks5tUFGigaJpZM4SBAx1>
.
|
|
@satya164 added a spell check and test to contributing.md |
ferrannp
approved these changes
Feb 14, 2018
eriveltonelias
pushed a commit
to eriveltonelias/react-native-paper
that referenced
this pull request
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.