Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pytorch backend flag #63

Closed
wants to merge 1 commit into from
Closed

add pytorch backend flag #63

wants to merge 1 commit into from

Conversation

gusye1234
Copy link

see #62

@abrown
Copy link
Collaborator

abrown commented Jul 13, 2022

@gusye1234, thanks for the contribution, but I don't think this is the right way to add this support:

  • first, we need to enable the flag in the WIT/WITX specification, e.g., here
  • then, we need to re-generate this bindings file so that it includes the new variant (note how the header of this file marks it as auto-generated)

As a separate issue, the WASI ecosystem has begun a transition from WITX specification files to WIT specification files, which means that the generation step for this file should switch to using WIT-based tools (i.e., wit-bindgen). I don't really expect you to have to worry too much about that (@brianjjones, do you want to take a look?) so I will create a separate issue for that: #64. @gusye1234, does that make sense? I am on Zulip if you want to discuss in more detail.

@abrown
Copy link
Collaborator

abrown commented Jul 13, 2022

(And apologies for contradicting myself in #62... I think I assumed this option was fine to add but now, looking at it more clearly, I think we need to be able to re-generated that file).

@gusye1234
Copy link
Author

Cool! Your suggestion to sync between this auto-generated file and WIT specification file is better.
I should pull a request here and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants