Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pytorch flag #25

Merged
merged 2 commits into from
Jul 18, 2022
Merged

add pytorch flag #25

merged 2 commits into from
Jul 18, 2022

Conversation

gusye1234
Copy link
Contributor

See more descriptions here

@abrown
Copy link
Collaborator

abrown commented Jul 14, 2022

@gusye1234, looks like the wasi-nn.abi.md file needs to be updated as well. Apologies for all of the thrash on this but this WIT syntax and tooling is still relatively new and some of the initial wrinkles still have to be ironed out. In #26, I added a CONTRIBUTING.md file that should explain how to use wit-abi to auto-generate the ABI file. Can you run those steps in this branch?

Signed-off-by: Jianbai Ye <[email protected]>
@gusye1234
Copy link
Contributor Author

Thanks for the detailed description!
Seem like wit-abi changed a little bit and unable to parse wit.md now, I ran into the error:

Error: failed to parse input "/Users/gus/Desktop/wasm/wasi-nn-spec/wasi-nn.wit.md"

Caused by:
    expected `type`, `resource`, or `func`, found '('
         --> /Users/gus/Desktop/wasm/wasi-nn-spec/wasi-nn.wit.md:90:15
          |
       90 | load: function(builder: graph-builder-array, encoding: graph-encoding, target: execution-target) -> expected<graph, error>

I used tags/wit-abi-0.4.0 for wit-abi, which I thought was the same version as the CI?

@abrown
Copy link
Collaborator

abrown commented Jul 16, 2022

Hm, well things are changing quickly in the WIT world. I seem to remember function being changed to func recently in the WIT syntax. I'll investigate more on Monday because it is unclear to me why the tool is failing if it matches the CI version.

@gusye1234
Copy link
Contributor Author

Hm, well things are changing quickly in the WIT world. I seem to remember function being changed to func recently in the WIT syntax. I'll investigate more on Monday because it is unclear to me why the tool is failing if it matches the CI version.

My bad! I looked down into the CI, and found out the tag for wit-abi is wit-abi-0.2.0. Now everything works perfectly!

@abrown abrown merged commit ae2ec68 into WebAssembly:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants