Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos and unclear wording #35

Merged
merged 10 commits into from
Dec 7, 2020
Merged

Fix typos and unclear wording #35

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
907c5f4
Make it clearer when we actually upload
imjoehaines Dec 4, 2020
1df6a0a
Add missing space to error message
imjoehaines Dec 4, 2020
7dfe79f
Add '(s)' as there can multiple source maps
imjoehaines Dec 4, 2020
bf7a063
Add bundle to success message when available
imjoehaines Dec 4, 2020
1d646b3
Change "and" to "or"
imjoehaines Dec 4, 2020
8516983
Fix typo in "received"
imjoehaines Dec 4, 2020
496091e
Improve error if missing all required arguments
imjoehaines Dec 4, 2020
b24e48e
Add a "to" in "Initiating upload to <URL>"
imjoehaines Dec 4, 2020
25aaa26
Clarify help text for browser URL arguments
imjoehaines Dec 4, 2020
4332f13
Improve error if missing all required arguments
imjoehaines Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing space to error message
  • Loading branch information
@imjoehaines
imjoehaines committed Dec 4, 2020
commit 1df6a0af72c823e5984c2cb91e602780dd7f50f8
2 changes: 1 addition & 1 deletion src/commands/UploadBrowserCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ function validateBrowserOpts (opts: Record<string, unknown>): void {
const anySingleSet = opts['sourceMap'] || opts['bundleUrl'] || opts['bundle']
const anyMultipleSet = opts['baseUrl'] || opts['directory']
if (anySingleSet && anyMultipleSet) {
throw new Error('Incompatible options are set. Use either single mode options (--source-map, --bundle, --bundle-url) or multiple mode options (--directory,--base-url).')
throw new Error('Incompatible options are set. Use either single mode options (--source-map, --bundle, --bundle-url) or multiple mode options (--directory, --base-url).')
}
if (!anySingleSet && !anyMultipleSet) throw new Error('Not enough options supplied')

Expand Down