Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and unclear wording #35

Merged
merged 10 commits into from
Dec 7, 2020
Merged

Fix typos and unclear wording #35

merged 10 commits into from
Dec 7, 2020

Conversation

imjoehaines
Copy link
Member

@imjoehaines imjoehaines commented Dec 4, 2020

Goal

Fixes a bunch of typos and unclear wording found when testing tool

Each is fixed in a separate commit, so may be easier to review that way

Uploading browser source map for "" should possibly be Preparing upload of browser source map for "", as we don’t initiate the upload til later. When an error occurs after this info, it’s not clear if the upload has partially completed.

Missing space in incompatible options error message

› Found 2 source map:
map needs pluralization (e.g. soure map(s)) when > 1 map found.

When uploading with the directory option, the success message says
✔ Success, uploaded bundle_b.js.map to https://upload.bugsnag.com/source-map in 555ms
but I assume the bundle was also uploaded because it does read it (above log was › Reading bundle file "bundle_b.js"). Maybe the success message should say uploaded map x & bundle y ?

In this error message:
ERROR --code-bundle-id or at least one of --app-version, --app-version-code and --app-bundle-version must be given
The and should be an or. Shouldn’t be possible to give a version code and bundle version.

Missing --source-map and --fetch: returns error:
ERROR --source-map is a required
maybe we should add “--source-map or --fetch” as required parameters?

^ For this one I changed it to --fetch or both --source-map and --bundle are required parameters as both --source-map and `--bundle1 are required

Typo in “Recieved”:
ERROR Recieved an error from the server.

› Initiating upload "https://upload.bugsnag.com/react-native-source-map" reads strangely. May be better as:
› Initiating upload to "https://upload.bugsnag.com/react-native-source-map" to make it a little clearer.

Copy link
Contributor

@bengourley bengourley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good except one error message I think could be clearer.

src/commands/UploadReactNativeCommand.ts Outdated Show resolved Hide resolved
@imjoehaines imjoehaines merged commit 5b99653 into next Dec 7, 2020
@imjoehaines imjoehaines deleted the wording-tweaks branch December 7, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants