Fix and improve summed variables implementation (including adding synapses to synapses support and start fixing spikegenerator) #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #49 [WIP]
We have three versions in the commits below that should be benchmarked against each other (see #49 discussion):
synapses * targets
threads in total (d2ff3ff )cudaMemset
to reset summed variables instead ofthrust::fill
(653d487)EDIT
This PR turned out to touch a couple of issue at the same time:
get_array_name
implementation now takes into account the different prefixes we use for device and host variables.I did not do the benchmarking that I suggested above. This could be done in #197 if it turns out to be relevant.