Skip to content

Commit

Permalink
Avoid removing backslashes from Dockerfiles
Browse files Browse the repository at this point in the history
foxundermoon/vs-shell-format#29
foxundermoon/vs-shell-format#62
mvdan/sh#424

The foxundermoon/vs-shell-format extension formats Dockerfiles, but it
shouldn't, because the underlying formatter mvdan/sh isn't engineered
for Dockerfiles. As explained in mvdan/sh#424,

> Removing the `\` is correct in shell, because a line ending in `&&`
> just continues the command in the following line.

This commit will disable Dockerfile formatting.
  • Loading branch information
br3ndonland committed Sep 18, 2020
1 parent 4074d3c commit c2f29e4
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion codium/User/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
"cSpell.spellCheckDelayMs": 5000,
"deno.unstable": false,
"[dockerfile]": {
"editor.defaultFormatter": "foxundermoon.shell-format"
"editor.formatOnSave": false
},
"[dotenv]": {
"editor.defaultFormatter": "foxundermoon.shell-format"
Expand Down Expand Up @@ -150,6 +150,7 @@
"editor.rulers": [80],
"files.eol": "\n"
},
"shellformat.effectLanguages": ["shellscript"],
"[typescript]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
Expand Down

0 comments on commit c2f29e4

Please sign in to comment.