This repository has been archived by the owner on Sep 27, 2019. It is now read-only.
Fix cross-compilation for iOS and possibly other platforms #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add package options
The libpcreposix library uses libpcre, so libpcre must come last (at least for static linking).
Fix link order
…or tests and binaries, which are needed, and bring in /usr/include even when crosscompiling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readline and edit libraries are referenced in the PCRE's cmake configuration but they're only used for tests and binaries which are not produced for the conan packages. As there's no check for that in the original cmake, if support for these libraries is not disabled an additional "-I /usr/include" gets added when cross-compiling for a platform that doesn't have those libraries available, such as iOS, since the system ones are found by CMake. This breaks compilation of the PCRE conan packages on those platforms.