This repository has been archived by the owner on Sep 27, 2019. It is now read-only.
Fix link order #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow-up question: Is this the correct branch? Or should I be submitting PRs to the testing branch? |
|
Hi @msteinert ! Thanks for your contribution! 🥇 We prefer to use testing branch to avoid uploads on CI. But as you are developing on a separated branch, there is no problem to merge into our stable branch directly. After to merge your PR we will update our testing branch to get synchronized. |
|
Looks like maybe different library names for debug mode on Windows ( |
The libpcreposix library uses libpcre, so libpcre must come last (at least for static linking).
|
Much thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libpcreposix library uses libpcre, so libpcre must come last (at
least for static linking).