Stackedit modularization: Plugins folders #595
Conversation
Instead of having every model which might need a provider having to specify every possible provider as input argument, we now have a plugin model which can expose a list of providers, which the event manager then will notify about when they are loaded. Conflicts: public/res/publisher.js public/res/sharing.js
For some reason, http:https://github.com/RobinThrift/gulp-requirejs is gone (404), but if you use http:https://github.com/bornkiller/gulp-requirejs then it works. This fixes issue benweet#596"
|
I don't think it would work (have you tested it?). |
|
Thanks for input. In the original code For example, Are there specific synchroinzers/publishers/sharing components you know will give problems? I have not tried with all of them (don't use all). But the principle applied here is that it should be included if the js-file responds to certain methods. I will gladly test with an example. And I should perhaps also document which methods should be present (undocumentded for now in |
jesperronn
changed the title
|
@benweet do you have an example of this:
Also, the interface between publisher, synchronizer and sharing would be more clean if they expose different methods, so that any object that implements specific methods could be a I really need your guidance here so that this branch can eventually be merged |
|
Hi, I prefer not to merge your work as I'm working on a complete rewrite of the project. Sorry about that. |
|
@benweet thanks for the update. any pointers, branches, ideas that you want to share to get feedback? |
|
No, it's a private repo at the moment. I'll let you know as soon as it become public. |
jesperronn
changed the title
UPDATE 2014-11-04: Need an example for testing, so don't merge until we know it works
To follow up on #542, this branch provides a modularized structure for loading plugins into Stackedit
Usage: PLugins are now defined in the
/public/pluginsfolder and are activated one place only: in the filepublic/res/plugins.js(and only once in this file as opposed to previously)Work done:
public/res/plugins.jspublisher.js,synchronizer.js,sharing.jsAnd it already works as is!
How it works: All plugins are registered in
public/res/plugins.js, which now loads each of the defined plugins by sending them to Publisher, Synchronizer, Sharing for initialization. After that theonPluginsLoadedevent is submitted.This fully solves the means of #542 but could be improved further so that for instance html snippets relevant for each plugin can be put in that specific directory and loaded only if relevant.