Skip to content

Commit

Permalink
Upgrade V8 to 9.2.230.10 (denoland#700)
Browse files Browse the repository at this point in the history
* We are floating a revert of v8/v8@7f9d7f0 because of the issue described in denoland#694.
* Upgrade ICU 68 -> 69
* Upgrade //build and //buildtools
* set v8_enable_shared_ro_heap = false to fix tests
  • Loading branch information
ry committed Jun 15, 2021
1 parent 8c79145 commit fe29835
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[submodule "v8"]
path = v8
url = https://chromium.googlesource.com/v8/v8
url = https://github.com/denoland/v8.git
[submodule "build"]
path = build
url = https://github.com/denoland/chromium_build.git
Expand Down
6 changes: 6 additions & 0 deletions .gn
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ default_args = {
use_dummy_lastchange = true
treat_warnings_as_errors = true

# To avoid test failure:
# Fatal error in ../../../v8/src/heap/read-only-spaces.cc, line 69
# Check failed: read_only_blob_checksum_ == snapshot_checksum (<unprintable>
# vs. 604745897).
v8_enable_shared_ro_heap = false

# TODO(ry) remove
v8_imminent_deprecation_warnings = false

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Rusty V8 Binding

V8 Version: 9.1.269.35
V8 Version: 9.2.230.10

[![ci](https://github.com/denoland/rusty_v8/workflows/ci/badge.svg?branch=main)](https://github.com/denoland/rusty_v8/actions)
[![crates](https://img.shields.io/crates/v/rusty_v8.svg)](https://crates.io/crates/rusty_v8)
Expand Down
2 changes: 1 addition & 1 deletion build
Submodule build updated 374 files
4 changes: 2 additions & 2 deletions src/icu.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
extern "C" {
fn udata_setCommonData_68(this: *const u8, error_code: *mut i32);
fn udata_setCommonData_69(this: *const u8, error_code: *mut i32);
}

/// This function bypasses the normal ICU data loading process and allows you to force ICU's system
Expand Down Expand Up @@ -38,7 +38,7 @@ extern "C" {
pub fn set_common_data(data: &'static [u8]) -> Result<(), i32> {
let mut error_code = 0i32;
unsafe {
udata_setCommonData_68(data.as_ptr(), &mut error_code);
udata_setCommonData_69(data.as_ptr(), &mut error_code);
}
if error_code == 0 {
Ok(())
Expand Down
2 changes: 1 addition & 1 deletion third_party/icu
Submodule icu updated 891 files
2 changes: 1 addition & 1 deletion v8
Submodule v8 updated from 399148 to b7957d

0 comments on commit fe29835

Please sign in to comment.